Remove @material-ui/styles dependency #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@material-ui/styles
is meant to be a standalone solution that can be used even when one is not using material ui components. In our case, we are using material ui components.For this case, @material-ui provides
@material-ui/core/styles
which override@material-ui/styles
and make sure there is a default theme provided, etc.: https://material-ui.com/styles/basics/#material-ui-core-styles-vs-material-ui-stylesMixing these two will lead to issues such as
className
conflict, etc.see: mui/material-ui#15867, mui/material-ui#8223, mui/material-ui#11628
Hence, this PR switches HURUmap UI to using
@material-ui/core/styles
exclusively.Related to: https://www.pivotaltracker.com/story/show/169497721
Type of change
Screenshots
N/A
Checklist: