Feature: Optimize the replica delay api logic #45148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: ============ Currently if in the Whole CK instance has one table is read only status then the API /replicas_status will throw error, xxx table is read only For make this monitor can work in prod env, we can catch the read only status instead of directly throw error Solution: ========= Return other normal table's delay value even if the CK instance has readonly Replicatedxxx table Please enter the commit message for your changes. Lines starting
mateng0915
force-pushed
the
replicas_status_api_optimize
branch
from
1ace36e
to
eae0f99
Compare
robot-ch-test-poll3
added
the
pr-improvement
alexey-milovidov
added
the
can be tested
pufit
requested changes
Feb 11, 2023
pufit
approved these changes
Feb 14, 2023
|
@pufit Hello pufit can you help merge this PR, thx |
Yes, sure. Just wanted to run CI before merging. It's not that I've expected any bug in your commit, just a good practice in general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Optimize behavior for a replica delay api logic in case the replica is read-only.
Description:
Currently if in the Whole CK instance has one table is read only status then the API /replicas_status will throw error, xxx table is read only and can not get other normal ReplicatedMergeTree table's delay value
Solution:
Return other normal table's delay value even if the CK instance has readonly Replicatedxxx table
Please enter the commit message for your changes. Lines starting