Replace domain IP types (IPv4, IPv6) with native #43221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll2
added
the
pr-not-for-changelog
|
IPv6 is not yet fully operational - parser isn't working properly... |
…IPv6 in casting to better match previous behavior, some cleanup, test fixed
…ext in cast function (will require review), docs appended
yakov-olkhovskiy
force-pushed
the
refactoring-ip-types
branch
from
b69b95d
to
c47f13a
Compare
There was a problem hiding this comment.
NOTE: this comment is outdated...
@alexey-milovidov BTW I'm not completely sure this is correct - probably it needs the same std::is_copy_constructible enabler for type U as above for type T (it will be a template template parameter I guess..)
This was referenced Jan 7, 2023
|
This commit will produce regression errors while trying to insert UInt32 as IPv4 without ::UInt32 like |
Closed
This was referenced Jan 31, 2023
This was referenced Feb 17, 2023
monogon-bot
pushed a commit
to monogon-dev/NetMeta
that referenced
this pull request
Feb 27, 2023
This is required because ClickHouse/ClickHouse#43221 forbids usage of reinterpret with IPv6 values Change-Id: I257feb0d4e930aed54cf58e8c6732ed747e2d14b
10 tasks
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 5, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 5, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 6, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 6, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 6, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 6, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 6, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 7, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 7, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 7, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 7, 2023
lizhou1111
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 7, 2023
lizhou1111
added a commit
to timeplus-io/proton
that referenced
this pull request
Dec 7, 2023
* functions fixed, test fixed, porting ClickHouse/ClickHouse#43221 * IPAddressDictionary fixed, test fixed, porting ClickHouse/ClickHouse#43221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
closes #14567