Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX-399] Fix training status bug #321

Merged
merged 2 commits into from
Apr 2, 2024
Merged

[DEVX-399] Fix training status bug #321

merged 2 commits into from
Apr 2, 2024

Conversation

sainivedh
Copy link
Contributor

@sainivedh sainivedh commented Mar 27, 2024 •
edited
Loading

Why

  • To remove constraint of user specifying model_type_id for training_logs

How

  • Make use of load_info() to get model version details

Tests

  • Existing training status tests should pass

Notes

@sainivedh sainivedh marked this pull request as draft March 27, 2024 07:29
@sainivedh sainivedh marked this pull request as ready for review March 27, 2024 09:37
@ackizilkale
Copy link
Contributor

I am happy with it, but please make sure David sees it before merged.

@sainivedh sainivedh merged commit 111786f into master Apr 2, 2024
17 checks passed
@sainivedh sainivedh deleted the DEVX-399-training-status-bug branch April 2, 2024 06:54
@sanjaychelliah sanjaychelliah mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackizilkale ackizilkale ackizilkale approved these changes

@deigen deigen Awaiting requested review from deigen

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sainivedh @ackizilkale