Fix lint #723
Fix lint #723
Conversation
| env: | ||
| CI: true | ||
| TERM: xterm-256color |
| env: | ||
| CI: true | ||
| TERM: xterm-256color | ||
| CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }} |
There was a problem hiding this comment.
I was seeing this warning from Cypress earlier:
This project has been configured to record runs on our Dashboard.
It currently has the projectId: n7g5qp
You also provided your Record Key, but you did not pass the --record flag.
This run will not be recorded.
If you meant to have this run recorded please additionally pass this flag.
cypress run --record
If you don't want to record these runs, you can silence this warning:
cypress run --record false
https://on.cypress.io/recording-project-runs
| CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }} | ||
| DEBUG: commit-info,cypress:server:record | ||
| # https://docs.cypress.io/guides/guides/continuous-integration.html#Environment-variables | ||
| COMMIT_INFO_BRANCH: ${{ github.head_ref }} | ||
| COMMIT_INFO_AUTHOR: ${{ github.event.sender.login }} | ||
| COMMIT_INFO_SHA: ${{ github.event.after }} |
There was a problem hiding this comment.
What was the reason for removing these environment variables? Since merging i'm getting errors like the following from cypress: https://github.com/jshjohnson/Choices/runs/283664081#step:5:0 :)
There was a problem hiding this comment.
@jshjohnson I've added them just to help commitinfo, but it was able to find the same information in the previous run. You may revert that, it doesn't hurt to have them here.
There was a problem hiding this comment.
But errors seems unrelated
There was a problem hiding this comment.
yeah i think i know where the problem is - we're not passing a value to --group in the cypress:ci script
There was a problem hiding this comment.
@jshjohnson github.event.after will not be available on push to master, so, if you would like to reuse the same action you may better remove COMMIT_INFO_SHA completely here
Prevents lint errors for cases like https://github.com/jshjohnson/Choices/runs/281570154
Also, it seems that since Cypress 3.5 it tolerates lack of record key, so, on PR originated by @jshjohnson we should start seeing beautiful Cypress decorations.