Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both new and old electron IDs #752

Merged
merged 64 commits into from
May 3, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
75ff425
Fix PU sum name for 0.3 cone training
steggema Apr 24, 2018
9faa2af
Merge remote-tracking branch 'jan/heppy_94X_dev_taumva' into merge_at…
cbernet Jul 3, 2018
aff9ccc
pileup analyzer now able to read a tfile with an histogram for each m…
cbernet Jul 10, 2018
29bdcff
added logging info messages, excluding 1st event from time report
cbernet Jul 10, 2018
d0c3f6b
added source file readable from anywhere
cbernet Jul 12, 2018
a3d7445
Add module and configuration that gets TGraphs so tau ID working poin…
steggema Jul 12, 2018
997f80b
added data files and interface for tau MVA ID
cbernet Jul 12, 2018
33febd3
Tau can now use mva tau isolation
cbernet Jul 12, 2018
2d550d1
small bug fix in event printout
cbernet Jul 12, 2018
9dec6ee
small fix
cbernet Jul 12, 2018
36a5855
mva opt updated
GaelTouquet Jul 18, 2018
2b6e715
Heppy: added tau id mva output renormalization (necessary to apply wo…
cbernet Jul 18, 2018
493cd5e
Merge remote-tracking branch 'colin/dev' into 94X_HTT
GaelTouquet Jul 18, 2018
bf58ffa
Merge pull request #3 from cbernet/dev
cbernet Jul 18, 2018
87cf052
Merge remote-tracking branch 'colin/94X_HTT' into 94X_HTT
GaelTouquet Jul 18, 2018
0f6713e
Heppy: better event printout
cbernet Jul 18, 2018
ddaf9d4
Merge remote-tracking branch 'colin/94X_HTT' into 94X_HTT
cbernet Jul 18, 2018
a87f378
corrected ordering of arguments
GaelTouquet Jul 20, 2018
7e7fd5e
Merge pull request #4 from GaelTouquet/94X_HTT
cbernet Jul 23, 2018
2a057ba
Heppy: streamlined isolation interface, enabling the use of electron …
cbernet Jul 23, 2018
042ced5
Merge remote-tracking branch 'colin/94X_HTT' into 94X_HTT
cbernet Jul 23, 2018
112c660
Heppy: tau behaves in a transparent way w/r other leptons
cbernet Jul 23, 2018
9077c26
dummy methods now return mva score, which is useful
cbernet Jul 23, 2018
419b210
using latest muon ID
GaelTouquet Jul 24, 2018
db96c05
tau.tauID(name) transparent as is in muon.py
GaelTouquet Jul 24, 2018
ef13217
Revert "using latest muon ID"
GaelTouquet Jul 24, 2018
d4b436f
new tau isolation numbering score
GaelTouquet Jul 24, 2018
b51965d
Tau ID simplified and cleaning
GaelTouquet Jul 24, 2018
7be5c90
cleaning
GaelTouquet Jul 24, 2018
d587d89
more cleaning
GaelTouquet Jul 24, 2018
33da160
fix logic
GaelTouquet Jul 24, 2018
3cc31f4
Merge pull request #5 from GaelTouquet/TauID_common
cbernet Jul 24, 2018
75407cb
Merge remote-tracking branch 'colin/Lepton_update' into 94X_HTT
cbernet Sep 7, 2018
030c139
removed obsolete line
cbernet Sep 11, 2018
e35e5fb
renamed IsoR to Iso
cbernet Sep 13, 2018
4a1545d
fix miniIso in comments
cbernet Sep 13, 2018
58cc8d5
Do not hold on to empty strings passed to getByLabel
Dr15Jones Dec 4, 2018
e9d1811
FWLite electron id
guitargeek Mar 5, 2018
99de3ce
Merge remote-tracking branch 'colin/htt_9_4_11_cand1_v1' into htt_9_4…
cbernet Dec 5, 2018
c62836b
Adaptaion of ElectronMVAID.py to new ElectronMVAEstimatorRun2.cc
lucastorterotot Nov 28, 2018
ea8539e
ElectronMVAID Fall17 V2 update with new Egamma code.
lucastorterotot Nov 29, 2018
0a61532
Code improvements : use of electronID instead of mvaIDRun2 implemente…
lucastorterotot Nov 29, 2018
7a916f9
ElectronID cleaning.
lucastorterotot Dec 7, 2018
ed86b3b
Removed useless lines and cut long line in code.
lucastorterotot Dec 10, 2018
fbd21c6
New comment in electronID_Egamma_dict.py to motivated its presence.
lucastorterotot Dec 10, 2018
89256e8
Colin's comments taken into account.
lucastorterotot Dec 11, 2018
129a7c1
Colin's comments taken into account - second time.
lucastorterotot Dec 11, 2018
824a006
Changed dicts names for electronID implementation.
lucastorterotot Dec 11, 2018
8d5c7b8
Merge pull request #6 from lucastorterotot/htt_9_4_11_cand1_v1
cbernet Dec 11, 2018
84a35ca
Cut based ele id Fall17 94X V2 first implementation.
lucastorterotot Jan 10, 2019
7f2bb4c
Electron effective areas changed from 92X to 94X.
lucastorterotot Jan 11, 2019
a1b3415
Cut based ele id corrections.
lucastorterotot Jan 11, 2019
3eeb511
Cut based ele id Fall17 94X V2 changed to not modify cff files.
lucastorterotot Jan 11, 2019
bc53573
Corrections.
lucastorterotot Jan 11, 2019
3fd8efb
Revert change in a comment in PhysicsTools/Heppy/python/physicsutils/…
lucastorterotot Jan 11, 2019
5c097f4
Comments from Colin taken into account.
lucastorterotot Jan 14, 2019
7c6e98c
central to eleID conflicts solved
GaelTouquet Apr 12, 2019
bd7006c
fix a double change
GaelTouquet Apr 12, 2019
042c3aa
Merge commit 'bd7006c265f' into merge_749
gpetruc Apr 15, 2019
0a58dfd
RecoEgamma/ElectronIdentification/python/FWLite: Declare also older I…
gpetruc Apr 15, 2019
cc8f214
RecoEgamma/ElectronIdentification/python/FWLite: support all WPs of F…
gpetruc Apr 16, 2019
8437c4e
Heppy LeptonAnalyzer: load also conversions and beam spot, for new El…
gpetruc Apr 15, 2019
a664cb5
Preserve support for older electron IDs and custom WPs
gpetruc Apr 15, 2019
ec463a9
Improve handling of cut-based WPs and countWP method
gpetruc Apr 16, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tau can now use mva tau isolation
  • Loading branch information
cbernet committed Jul 12, 2018
commit 33febd30f87817504927dd513219884360e1c056
8 changes: 8 additions & 0 deletions PhysicsTools/Heppy/python/physicsobjects/Tau.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
from PhysicsTools.Heppy.physicsobjects.Lepton import Lepton
from PhysicsTools.Heppy.physicsutils.TauDecayModes import tauDecayModes
from PhysicsTools.Heppy.physicsutils.TauMVAID import tau_mvaid_2017 as tau_mvaid

import math

# Find all tau IDs here:
Expand All @@ -25,6 +27,12 @@ def mvaId(self):
'''For a transparent treatment of electrons, muons and taus. Returns -99'''
return -99

def mva_score(self):
return tau_mvaid.score(self)

def mva_passes(self, working_point):
return tau_mvaid.passes(working_point)

def dxy_approx(self, vertex=None):
'''Returns standard dxy for an arbitrary passed vertex'''
if vertex is None:
Expand Down
10 changes: 8 additions & 2 deletions PhysicsTools/Heppy/python/physicsutils/TauMVAID.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,15 @@ def threshold(self, pt, working_point):

basedir = '$CMSSW_BASE/src/PhysicsTools/Heppy/data/'
working_points = dict(
Eff50 = 'RecoTauTag_tauIdMVAIsoDBoldDMwLT2017v2WPEff50.root',
Eff90 = 'RecoTauTag_tauIdMVAIsoDBoldDMwLT2017v2WPEff90.root'
Eff40 = 'RecoTauTag_tauIdMVAIsoDBoldDMwLT2017v2WPEff40.root', #VVTight
Eff50 = 'RecoTauTag_tauIdMVAIsoDBoldDMwLT2017v2WPEff50.root', #VTight
Eff60 = 'RecoTauTag_tauIdMVAIsoDBoldDMwLT2017v2WPEff60.root', #Tight
Eff70 = 'RecoTauTag_tauIdMVAIsoDBoldDMwLT2017v2WPEff70.root', #Medium
Eff80 = 'RecoTauTag_tauIdMVAIsoDBoldDMwLT2017v2WPEff80.root', #Loose
Eff90 = 'RecoTauTag_tauIdMVAIsoDBoldDMwLT2017v2WPEff90.root',
Eff95 = 'RecoTauTag_tauIdMVAIsoDBoldDMwLT2017v2WPEff95.root' #VVLoose
)

for wp in working_points:
working_points[wp] = '/'.join([basedir, working_points[wp]])

Expand Down