add "enable_fxaa" in rendering.global.json to enable/disable fxaa pass #218
Conversation
engine/source/runtime/resource/res_type/global/global_rendering.h
Outdated
Show resolved
Hide resolved
| @@ -192,8 +194,8 @@ namespace Pilot | |||
| fxaa_pass.updateAfterFramebufferRecreate( | |||
| main_camera_pass.getFramebufferImageViews()[_main_camera_pass_post_process_buffer_odd]); | |||
| combine_ui_pass.updateAfterFramebufferRecreate( | |||
| main_camera_pass.getFramebufferImageViews()[_main_camera_pass_backup_buffer_even], | |||
| main_camera_pass.getFramebufferImageViews()[_main_camera_pass_backup_buffer_odd]); | |||
| main_camera_pass.getFramebufferImageViews()[_main_camera_pass_backup_buffer_odd], | |||
There was a problem hiding this comment.
the _main_camera_pass_backup_buffer_odd VkImageView is used as the scene_input_attachment now no matter enable or disable FXAA pass. and the _main_camera_pass_backup_buffer_even is used as the ui_input_attachment. it doesn't make any difference if not changed the order. for easy understanding, i think the parameter should follow the definition void CombineUIPass::updateAfterFramebufferRecreate(VkImageView scene_input_attachment, VkImageView ui_input_attachment).
| @@ -27,6 +27,9 @@ namespace Pilot | |||
| { | |||
| RenderPass::initialize(nullptr); | |||
|
|
|||
| const MainCameraPassInitInfo* _init_info = static_cast<const MainCameraPassInitInfo*>(init_info); | |||
There was a problem hiding this comment.
local variable naming should be const MainCameraPassInitInfo* init_info
There was a problem hiding this comment.
the init_info has been used in const RenderPassInitInfo* init_info as the parameter of initialize function. i referenced the initialize function of ColorGradingPass which used this naming style.
|
@hyv1001 please check and assess if these changes should be accepted |
No description provided.