Use <nlohmann/json_fwd.hpp>.
#1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We identified recompiling JSON templates to contribute noticably
to the compile time:
**** Templates that took longest to instantiate:
16889 ms: nlohmann::basic_json<>::parse<const char *> (42 times, avg 402 ms)
12363 ms: nlohmann::basic_json<>::basic_json (127 times, avg 97 ms)
10129 ms: nlohmann::detail::parser<nlohmann::basic_json<>, nlohmann::detail::i... (42 times, avg 241 ms)
7934 ms: nlohmann::detail::parser<nlohmann::basic_json<>, nlohmann::detail::i... (42 times, avg 188 ms)
6145 ms: nlohmann::basic_json<>::json_value::json_value (211 times, avg 29 ms)
Fortunately, we can avoid the issue by using a forward declaration.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 27, 2024
pramodk
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We identified recompiling JSON templates to contribute noticably to the compile time:
Fortunately, we can avoid the issue by using a forward declaration.