-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the RunOnce decorator node #472
Conversation
It is ok for me to merge this |
bc2ce53
to
41c1f2e
Compare
Signed-off-by: Gaël Écorchard <[email protected]>
Co-authored-by: Davide Faconti <[email protected]>
I changed according to your wish but the functionality was not affected. |
I am still thinking about what the desired behavior is for Asynchronous children. May be this make more sense? auto status = child_node_->executeTick();
if(status == NosteStatus::SUCCESS || status == NosteStatus::FAILURE) {
already_ticked_ = true;
}
return status; Otherwise we don't complete RUNNING children |
I thought that the async child would change it's status without the need to be ticked. Am I right? |
no, not necessarily. This is much safer, in my opinion |
Merged with some important improvements |
Nice, sorry for not having reacted on this. |
This adds a RunOnce decorator node that will call its child'
executeTick()
only once. After the first time, it'll return the return value of child'sstatus()
.Signed-off-by: Gaël Écorchard [email protected]