Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop #80

Closed
BriceRenaudeau opened this issue Apr 1, 2019 · 3 comments
Closed

Infinite loop #80

BriceRenaudeau opened this issue Apr 1, 2019 · 3 comments
Assignees

Comments

@BriceRenaudeau
Copy link

Hi,
I would like to know if there is a simple way to make an infinite loop.
The "RetryUntilSuccesful" node has a limit num_attempts.

It is possible to make possible by changing retry_node.cpp (line 55) :
while (try_index_ < max_attempts_)
into :
while (try_index_ < max_attempts_ || max_attempts_==-1)
And set max_attempts_ as an int.

Or should I create my own DecoratorNode.

@facontidavide
Copy link
Collaborator

I guess this change makes lot of sense for many users.
I will include it.

@facontidavide
Copy link
Collaborator

Done :)

@BriceRenaudeau
Copy link
Author

Thank you it's really good.

You forgot to implement it in the retry_node :
(line 55) while (try_index_ < max_attempts_ || max_attempts_ == -1)

@facontidavide facontidavide self-assigned this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants