-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul TravisCI #4207
Overhaul TravisCI #4207
Conversation
8d25dc7
to
2298899
Compare
I was going to try to fix the Python3 + raw Makefile build, but I realized that we weren't testing it before. So I'll leave that for someone else to fix. But I'm skipping it more explicitly now. |
2298899
to
bbb4efd
Compare
LINE "WITH_PYTHON_LAYER := 1" | ||
|
||
if $WITH_PYTHON3 ; then | ||
# XXX doesn't work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For notes like this we like to use TODO(handle)
like the TODO(shelhamer)
you see in the Caffe code. XXX
isn't currently used in the project for highlighting comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Want me to assign it to anyone in particular?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I read this as the author of the TODO, and not the assignee, so TODO(lukeyeager)
is fine. Don't worry, it's not a promise to do it yourself haha. Although versioning records the line author it's nice to have a quick reference for who thought of the TODO in case there are later questions or you want to search for commits by the same author for context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
191bd11
to
79db9c4
Compare
I've removed the protobuf3 build cache:
|
* Run on Ubuntu 14.04 * Test cuDNN builds * Build with OpenBLAS NOTE: Python3 build only works with CMake
79db9c4
to
4bf4b18
Compare
I've done all I plan to do for this PR. Please let me know if other changes are necessary. |
Nice, since you trimmed the CUDA dependencies, is it building faster now? |
The build didn't speed up, but installing dependencies doesn't take as long. As expected. |
Thanks for the CI care @lukeyeager! These are welcome improvements. |
Sure thing. Can't wait to solve #3351 so we can cut the test matrix in half. |
[testing] Overhaul TravisCI
scripts/travis/
for clarity and consistencyTODO:
wontfix: