Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set keptn prometheus service and RBAC namespace to Orkestra #398

Merged

Conversation

nitishm
Copy link
Contributor

@nitishm nitishm commented Oct 6, 2021

Closes #397

Signed-off-by: Nitish Malhotra [email protected]

@nitishm
Copy link
Contributor Author

nitishm commented Oct 6, 2021

@scotty-c Please try this out and let me know if you encounter any issues

@codecov-commenter
Copy link

Codecov Report

Merging #398 (164af9d) into main (a413430) will decrease coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   70.40%   69.82%   -0.59%     
==========================================
  Files           9        9              
  Lines         517      517              
==========================================
- Hits          364      361       -3     
- Misses        132      134       +2     
- Partials       21       22       +1     
Impacted Files Coverage Δ
controllers/appgroup_controller.go 77.19% <0.00%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a413430...164af9d. Read the comment docs.

@scotty-c
Copy link

scotty-c commented Oct 6, 2021

@nitishm one change i would make is to change this command kubectl create -f bookinfo-keptn-cm.yaml -n orkestra to
kubectl create -f examples/keptn/bookinfo.yaml so the user can stay in the root directory to run the demo

@scotty-c
Copy link

scotty-c commented Oct 6, 2021

LGTM

@nitishm nitishm merged commit 6a28116 into Azure:main Oct 6, 2021
@nitishm nitishm deleted the nitishm/bug/397/prometheus-ns-to-orkestra branch October 6, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orkestra helm chart deploy with keptn requires istio-system to be created before it can be deployed
3 participants