Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the DAG application logic into Graph #371

Merged
merged 4 commits into from
Aug 26, 2021

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Aug 24, 2021

  • Refactors the application logic that was passed to the individual workflows into the DAG graph creation
  • Template Generation no longer has the complex subchart application logic

@nitishm
Copy link
Contributor

nitishm commented Aug 25, 2021

Overall LGTM - address the unit tests CI failures and we should be good to merge this in.

@jonathan-innis jonathan-innis force-pushed the graph-refactor branch 4 times, most recently from 879a672 to d313d24 Compare August 25, 2021 22:34
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #371 (d8d4feb) into main (3989de1) will increase coverage by 2.34%.
The diff coverage is 74.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   29.70%   32.04%   +2.34%     
==========================================
  Files          13       13              
  Lines         707      596     -111     
==========================================
- Hits          210      191      -19     
+ Misses        487      398      -89     
+ Partials       10        7       -3     
Impacted Files Coverage Δ
pkg/workflow/workflow.go 0.00% <ø> (ø)
pkg/workflow/workflow_forward.go 0.00% <0.00%> (ø)
pkg/workflow/workflow_reverse.go 0.00% <0.00%> (ø)
pkg/workflow/workflow_rollback.go 0.00% <0.00%> (ø)
pkg/workflow/templates.go 81.25% <68.57%> (-2.20%) ⬇️
pkg/workflow/graph.go 92.98% <92.85%> (+82.02%) ⬆️
controllers/appgroup_controller.go 73.23% <0.00%> (-4.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3989de1...d8d4feb. Read the comment docs.

@jonathan-innis jonathan-innis force-pushed the graph-refactor branch 2 times, most recently from 629f611 to 3d105f5 Compare August 26, 2021 05:04
@jonathan-innis jonathan-innis force-pushed the graph-refactor branch 3 times, most recently from 8e65a1e to f7defc4 Compare August 26, 2021 16:42
nitishm
nitishm previously approved these changes Aug 26, 2021
Copy link
Contributor

@nitishm nitishm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@nitishm nitishm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT 🚀

@nitishm nitishm merged commit 5da5590 into Azure:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants