-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the DAG application logic into Graph #371
Conversation
jonathan-innis
commented
Aug 24, 2021
•
edited
Loading
edited
- Refactors the application logic that was passed to the individual workflows into the DAG graph creation
- Template Generation no longer has the complex subchart application logic
4be8ebb
to
8002abc
Compare
8002abc
to
8702b67
Compare
Overall LGTM - address the unit tests CI failures and we should be good to merge this in. |
879a672
to
d313d24
Compare
d313d24
to
cc64fd7
Compare
Codecov Report
@@ Coverage Diff @@
## main #371 +/- ##
==========================================
+ Coverage 29.70% 32.04% +2.34%
==========================================
Files 13 13
Lines 707 596 -111
==========================================
- Hits 210 191 -19
+ Misses 487 398 -89
+ Partials 10 7 -3
Continue to review full report at Codecov.
|
629f611
to
3d105f5
Compare
…kestra into graph-refactor
8e65a1e
to
f7defc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
f7defc4
to
74c0adb
Compare
30044fa
to
93bfc2c
Compare
93bfc2c
to
d8d4feb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIP IT 🚀