Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azureusgovernment to environment list, fix Makefile #695

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

rguptar
Copy link
Contributor

@rguptar rguptar commented Apr 20, 2022

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.
  1. The Azure CLI az cloud list -o table and the various Azure SDKs refer to govcloud as AzureUSGovernment. This PR adds support for that name. This broke our deployment when using the Azure Key Vault Provider for Secrets Store CSI Driver.
  2. Minor fixes were made to the Makefile so it works out of the box. It was also renamed.

@jhendrixMSFT
Copy link
Member

I'm unclear on why this is now a problem. The naming has been like this for years. Can you please clarify?

@jhendrixMSFT
Copy link
Member

Fixes #624

@jhendrixMSFT jhendrixMSFT merged commit 7525a9b into Azure:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants