Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support join & leave for member controllers #184

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: support join & leave for member controllers #184

wants to merge 2 commits into from

Conversation

zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Jul 15, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Run e2e test in the local

Ran 22 of 22 Specs in 604.438 seconds
SUCCESS! -- 22 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestE2E (604.44s)
PASS
ok      go.goms.io/fleet-networking/test/e2e    604.457s

Special notes for your reviewer

Note: the changes will break v1alpha1 imc feature.

@zhiying-lin zhiying-lin marked this pull request as draft July 15, 2024 09:58
@zhiying-lin zhiying-lin force-pushed the join-leave-1 branch 2 times, most recently from 4289d12 to 0f3b9e9 Compare July 23, 2024 07:34
@zhiying-lin zhiying-lin marked this pull request as ready for review August 5, 2024 11:11
michaelawyu
michaelawyu reviewed Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, LGTM.

pkg/controllers/member/endpointslice/controller.go Outdated Show resolved Hide resolved
@zhiying-lin zhiying-lin marked this pull request as draft August 8, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelawyu michaelawyu michaelawyu left review comments

@jwtty jwtty jwtty left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiying-lin @michaelawyu @jwtty