-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming: Status suffix #2448
Merged
Merged
Naming: Status suffix #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
Porges,
matthchr,
babbageclunk and
super-harsh
as code owners
August 12, 2022 03:14
Merged
3 tasks
matthchr
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
super-harsh
approved these changes
Aug 17, 2022
theunrepentantgeek
force-pushed
the
improve/status-naming
branch
from
August 18, 2022 01:25
6a88edf
to
7cbc4b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To reduce the number of changes in #2084, we want to pull naming changes forward, allowing more meaningful review.
This PR changes our standard suffix from
_Status
to_STATUS
and updates all affected code.Prerequisites
Special notes for your reviewer:
_Status
to_STATUS
doesn't reorder types)__
) in file names now won't happenStatusARM
has a word break,STATUSARM
does not, so we explicitly force filenames to split intostatus_arm
to maintain naming conventionsHow does this PR make you feel:
If applicable: