Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming: Status suffix #2448

Merged
merged 11 commits into from
Aug 18, 2022
Merged

Naming: Status suffix #2448

merged 11 commits into from
Aug 18, 2022

Conversation

theunrepentantgeek
Copy link
Member

@theunrepentantgeek theunrepentantgeek commented Aug 12, 2022

What this PR does / why we need it:

To reduce the number of changes in #2084, we want to pull naming changes forward, allowing more meaningful review.

This PR changes our standard suffix from _Status to _STATUS and updates all affected code.

Prerequisites

Special notes for your reviewer:

  • Type sorting for file generation is now case insensitive (so that the change from _Status to _STATUS doesn't reorder types)
  • Double underscores (__) in file names now won't happen
  • While StatusARM has a word break, STATUSARM does not, so we explicitly force filenames to split into status_arm to maintain naming conventions

How does this PR make you feel:
gif

If applicable:

  • this PR contains tests

Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theunrepentantgeek theunrepentantgeek merged commit 022ea95 into main Aug 18, 2022
@theunrepentantgeek theunrepentantgeek deleted the improve/status-naming branch August 18, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants