Fix use of API Version in reconciler #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
Porges,
matthchr,
babbageclunk and
super-harsh
as code owners
matthchr
requested changes
Jul 26, 2022
|
|
||
| apiVersion, err := genruntime.GetAPIVersion(metaObject, scheme) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
I think we should avoid panic in the reconciler codepaths as much as we can? I know it makes it more awkward to use but can we return err here instead?
There was a problem hiding this comment.
Agree with @matthchr here.
There was a problem hiding this comment.
I was on the fence; originally wrote it with errors and then changed to use a panic to reduce boilerplate.
Changed it back.
matthchr
approved these changes
Jul 27, 2022
super-harsh
approved these changes
Jul 27, 2022
theunrepentantgeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #[issue number]
What this PR does / why we need it:
The API version associated with a resource is the one that should always be used when making ARM REST API calls. This wasn't the case, as documented in #2416
Fixes #2416
Special notes for your reviewer:
Thanks to @matthchr for helping to track down the issue.
How does this PR make you feel:
