Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain original API version in LocalPackageReference #2294

Merged
merged 13 commits into from
Jun 9, 2022

Conversation

theunrepentantgeek
Copy link
Member

@theunrepentantgeek theunrepentantgeek commented May 19, 2022

What this PR does / why we need it:

@matthchr noticed that a couple of our configuration errors were giving some odd recommendations (formatted for clarity):

Error during code generation:
failed during pipeline stage 21/63:
Apply export filters to reduce the number of generated types:
group dbformariadb:
version 2018-06-01 not seen (did you mean 20180601?):
version 2018-06-01: type ServersDatabases not seen (did you mean ServersDatabase?):
type ServersDatabases: $exportAs: Database not consumed

On one line it indicates 2018-05-01 was not seen, but then it is quoted it on the very next line.
Also, the suggestion is incorrect as we don't want to elide the hyphens (-)

The root cause is that in LocalPackageReference instances we were removing the hyphens as a part of constructing the package name. Fix is to retain the apiVersion independently of the packge version.

Prerequisites

How does this PR make you feel:
gif

@theunrepentantgeek theunrepentantgeek self-assigned this May 19, 2022
@theunrepentantgeek theunrepentantgeek marked this pull request as draft May 19, 2022 22:54
@theunrepentantgeek theunrepentantgeek changed the base branch from main to fix/type-target-wildcards June 2, 2022 00:07
@theunrepentantgeek theunrepentantgeek marked this pull request as ready for review June 2, 2022 21:20
@theunrepentantgeek theunrepentantgeek added this to the v2.0.0-beta.1 milestone Jun 6, 2022
Base automatically changed from fix/type-target-wildcards to main June 9, 2022 03:30
@matthchr matthchr merged commit a062767 into main Jun 9, 2022
@matthchr matthchr deleted the fix/version-recommendations branch June 9, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants