-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain original API version in LocalPackageReference #2294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
Porges,
matthchr,
babbageclunk and
super-harsh
as code owners
May 19, 2022 03:03
1 task
theunrepentantgeek
force-pushed
the
fix/version-recommendations
branch
from
June 2, 2022 00:06
d0eeec1
to
0ae881f
Compare
theunrepentantgeek
changed the base branch from
main
to
fix/type-target-wildcards
June 2, 2022 00:07
matthchr
approved these changes
Jun 8, 2022
Prerequisite for allowing wildcards
theunrepentantgeek
force-pushed
the
fix/version-recommendations
branch
from
June 9, 2022 04:02
da63739
to
c43e56e
Compare
theunrepentantgeek
force-pushed
the
fix/version-recommendations
branch
from
June 9, 2022 04:44
c43e56e
to
6c2fee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
@matthchr noticed that a couple of our configuration errors were giving some odd recommendations (formatted for clarity):
On one line it indicates
2018-05-01
was not seen, but then it is quoted it on the very next line.Also, the suggestion is incorrect as we don't want to elide the hyphens (
-
)The root cause is that in
LocalPackageReference
instances we were removing the hyphens as a part of constructing the package name. Fix is to retain theapiVersion
independently of the packge version.Prerequisites
How does this PR make you feel: