Fix conversion webhooks in operator bundle #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that recent versions of OLM and operator-sdk support conversion webhooks, we can remove some of the scaffolding and use of cert-manager.
These aren't needed any longer - OLM and operator-sdk set up certificates between the webhook service, pod, crds and webhook configs.
This has much better support for conversion webhooks.
babbageclunk
requested review from
davefellows,
matthchr,
Porges and
theunrepentantgeek
as code owners
babbageclunk
changed the title
matthchr
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The previously released operator bundle wasn't setting up conversion webhooks properly, so any custom resource with multiple versions would encounter problems reconciling. This updates the bundle generation to use the latest release of operator-sdk, and corrects the webhook config on the multi-version CRDs so that they refer to the webhook service OLM creates, since that's the one that it sets up certificates for.
The azureoperator-webhook-service has been removed.
Since OLM manages the certificate setup for the webhooks, I've also removed the cert-manager annotations from the CRDs, and removed the cert-manager setup from the installation instructions.
Closes #1718
How does this PR make you feel:
If applicable: