Refactor: remove dependency on the v1.1.0-alpha terraform #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the dependency on the v1.1.0-alpha `terraform` only for the `terraform add` command. Instead, depends on the github.com/magodo/tfadd. Correspondingly, removing the SDK schema generator and generated files, which is offloaded to the github.com/magodo/tfadd. But we still need to generate the resource mapping here. Additionally, as the `terraform-exec` now depends on the `hcl-install`, we are also migrating to using it. However, instead of using the upstream one, we use a forked repo, which has an additional feature to specify version constraint when searching for any fs source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependency on the v1.1.0-alpha
terraformonly for theterraform addcommand. Instead, depends on the github.com/magodo/tfadd. With this change, we are no longer bound to a specific terraform version. Any terraform version works as long as it is later than v0.12.Correspondingly, removing the SDK schema generator and generated files, which is offloaded to the https://github.com/magodo/tfadd. But we still need to generate the resource mapping here.
Additionally, as the
terraform-execnow depends on thehcl-install, we are also migrating to using it. However, instead of using the upstream one, we use a forked repo, which has an additional feature to specify version constraint when searching for any fs source.