Avoid terraform init for import workspaces when --dev-provider is specified
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… specified For environment that has `dev_overrides` correctly setup for the providers, users can use `--dev-provider` to indicate instead of using the pinned version, use the local dev provider. Another effect of using `dev_overrides` is that it will not check the dependency lock for each terraform command, hence avoid calculating the provider hash everytime. This saves us a bit of CPU time, especially we are running `terraform` commands in parallel. Therefore, this PR extends the `--dev-provider` a bit to not only remove the version constraint in the `terraform.tf`, it will also avoid the `terraform init` for the import directories, as the follow up terraform command will not use that file at all (given `dev_overrides`). This saves us some CPU time during `Init()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For environment that has
dev_overridescorrectly setup for the providers, users can use--dev-providerto indicate instead of using the pinned version, use the local dev provider. Another effect of usingdev_overridesis that it will not check the dependency lock for each terraform command, hence avoid calculating the provider hash everytime. This saves us a bit of CPU time, especially we are runningterraformcommands in parallel.Therefore, this PR extends the
--dev-providera bit to not only remove the version constraint in theterraform.tf, it will also avoid theterraform initfor the import directories, as the follow up terraform command will not use that file at all (givendev_overrides). This saves us some CPU time duringInit().