Fix another panic in debounce module related to move events

Fixes notify-rs#100
Awfa · Nov 19, 2016 · b124c36 · b124c36
1 parent 6f58cce
commit b124c36
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,9 +2,10 @@
 
 ## 3.0.1
 
-- FIX: \[macOS\] Fix panic in debounce module related to move events. [#99]
+- FIX: \[macOS\] Fix two panics in debounce module related to move events. [#99], [#100]
 
 [#99]: https://github.com/passcod/notify/issues/99
+[#100]: https://github.com/passcod/notify/issues/100
 
 
 ## 3.0.0

diff --git a/src/debounce/mod.rs b/src/debounce/mod.rs
@@ -114,7 +114,8 @@ impl Debounce {
                                 restart_timer(timer_id, path, &mut self.timer);
                             }
                             _ => {
-                                // this code can only be reached with fsevents because it may repeat a rename event for a file that has been renamed before
+                                // this code can only be reached with fsevents because it may
+                                // repeat a rename event for a file that has been renamed before
                                 // (https://github.com/passcod/notify/issues/99)
                             }
                         }
@@ -146,7 +147,15 @@ impl Debounce {
                                 *operation = Some(op::REMOVE);
                                 restart_timer(timer_id, path, &mut self.timer);
                             }
-                            // renaming a deleted file is impossible
+                            Some(op::REMOVE) => {
+
+                                // file has been renamed and then removed / keep write event
+                                // this code can only be reached with fsevents because it may
+                                // repeat a rename event for a file that has been renamed before
+                                // (https://github.com/passcod/notify/issues/100)
+                                restart_timer(timer_id, path, &mut self.timer);
+                            }
+                            // CLOSE_WRITE and RESCAN aren't tracked by operations_buffer
                             _ => {
                                 unreachable!();
                             }

diff --git a/tests/debounce.rs b/tests/debounce.rs
@@ -356,6 +356,42 @@ fn create_rename_write_create() { // fsevents
     ]);
 }
 
+// https://github.com/passcod/notify/issues/100
+#[test]
+fn create_rename_remove_create() { // fsevents
+    let tdir = TempDir::new("temp_dir").expect("failed to create temporary directory");
+
+    sleep_macos(10);
+
+    let (tx, rx) = mpsc::channel();
+    let mut watcher: RecommendedWatcher = Watcher::new(tx, Duration::from_secs(DELAY_S)).expect("failed to create debounced watcher");
+    watcher.watch(tdir.mkpath("."), RecursiveMode::Recursive).expect("failed to watch directory");
+
+    tdir.create("file1");
+
+    sleep_macos(35_000);
+
+    tdir.rename("file1", "file2");
+    tdir.remove("file2");
+    sleep_macos(10);
+    tdir.create("file3");
+
+    if cfg!(target_os="macos") {
+        assert_eq!(recv_events_debounced(&rx), vec![
+            DebouncedEvent::Create(tdir.mkpath("file1")),
+            DebouncedEvent::NoticeRemove(tdir.mkpath("file1")),
+            DebouncedEvent::NoticeRemove(tdir.mkpath("file2")),
+            // DebouncedEvent::Remove(tdir.mkpath("file1")), BUG: There should be a remove event for file1
+            DebouncedEvent::Remove(tdir.mkpath("file2")),
+            DebouncedEvent::Create(tdir.mkpath("file3")),
+        ]);
+    } else {
+        assert_eq!(recv_events_debounced(&rx), vec![
+            DebouncedEvent::Create(tdir.mkpath("file3")),
+        ]);
+    }
+}
+
 #[test]
 fn write_rename_file() {
     let tdir = TempDir::new("temp_dir").expect("failed to create temporary directory");