Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on usage of reference types in fields #2733

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

CountBleck
Copy link
Member

Changes proposed in this pull request:
⯈ Fix stringified nullable reference types
⯈ Report upon usage of reference types in fieldd

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

The extra } at the end is clearly a mistake from writing that template
literal.
Since reference types can't be written to linear memory, they don't have
proper byte sizes, which triggers an assert. Instead, the compiler
should signal its lack of support for this feature.

Fixes AssemblyScript#2726.
@dcodeIO dcodeIO merged commit 321ed3d into AssemblyScript:main Aug 13, 2023
12 checks passed
@CountBleck CountBleck deleted the no-externref-in-fields branch August 15, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants