Skip to content

Commit

Permalink
Fix prop types silently being evaluated to nothing (coryhouse#549)
Browse files Browse the repository at this point in the history
  • Loading branch information
vinczemarton authored and coryhouse committed Mar 26, 2018
1 parent dd68d50 commit b94e504
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions src/types/index.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
// Centralized propType definitions
import PropTypes from 'prop-types';

const { shape, number, bool, string } = PropTypes;
import { shape, number, bool, string, oneOfType } from 'prop-types';

export const fuelSavings = shape({
newMpg: PropTypes.oneOf[number,string],
tradeMpg: PropTypes.oneOf[number,string],
newPpg: PropTypes.oneOf[number,string],
tradePpg: PropTypes.oneOf[number,string],
milesDriven: PropTypes.oneOf[number,string],
newMpg: oneOfType([number,string]),
tradeMpg: oneOfType([number,string]),
newPpg: oneOfType([number,string]),
tradePpg: oneOfType([number,string]),
milesDriven: oneOfType([number,string]),
milesDrivenTimeframe: string,
displayResult: bool,
dateModified: string,
Expand All @@ -17,7 +15,7 @@ export const fuelSavings = shape({
});

export const savings = shape({
monthly: PropTypes.oneOf[number,string],
annual: PropTypes.oneOf[number,string],
threeYear: PropTypes.oneOf[number,string],
monthly: oneOfType([number,string]),
annual: oneOfType([number,string]),
threeYear: oneOfType([number,string]),
});

0 comments on commit b94e504

Please sign in to comment.