Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement "Load More" functionality to the contributor page #353

Merged

Conversation

amanrajrana
Copy link
Contributor

@amanrajrana amanrajrana commented Sep 27, 2023

issue: #352

Pull Request Overview:

This pull request introduces the "Load More" functionality to the contributor page, addressing the issue outlined in #352. Users can now load additional contributors beyond the initial set, enhancing the user experience.

Changes Made:

  • Added "Load More" functionality to the contributor page.
  • Improved user experience by allowing users to load more contributors seamlessly.

Testing:

  • Tested the "Load More" feature extensively to ensure it functions as expected.
  • Verified that data is fetched correctly and that there are no performance issues.

Screenshot

  • screenshot 1
screenshot
  • screenshot 2: when there is no more list
screenshot2

Please review this pull request, and your feedback is much appreciated.

Issue ArslanYM#352:

Added the "Load More" feature to the contributor page, allowing users to load additional contributors beyond the initial set. This enhancement is in line with the feature branch "feature/add-load-more-contributors."
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starter-hive ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 4:37pm

@ArslanYM
Copy link
Owner

@amanrajrana The contributors are not loading in the PR preview. Can you check this?

@amanrajrana
Copy link
Contributor Author

@amanrajrana The contributors are not loading in the PR preview. Can you check this?

@ArslanYM OK let me check. It was working fine in my local environment!

@amanrajrana amanrajrana force-pushed the feature/#352-add-load-more-contributors branch from 68546f9 to e557362 Compare September 27, 2023 16:33
@amanrajrana
Copy link
Contributor Author

@ArslanYM Resolve "Contributors list not loading" issue. Now the feature functions correctly in the production environment.

@ArslanYM
Copy link
Owner

@amanrajrana Thankyou for the feature.

Copy link
Owner

@ArslanYM ArslanYM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ArslanYM ArslanYM merged commit 6022817 into ArslanYM:main Sep 27, 2023
2 checks passed
@amanrajrana amanrajrana deleted the feature/#352-add-load-more-contributors branch September 27, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants