Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Improve unlock mechanism when changing master key #12

Closed
ghost opened this issue Aug 18, 2019 · 2 comments
Closed

[Suggestion] Improve unlock mechanism when changing master key #12

ghost opened this issue Aug 18, 2019 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Aug 18, 2019

Change master key after setting up Windows Hello, then lock and unlock the database, you'll see that this plugin fails unlocking the database.
image
1)It should prompt for standard unlock when failed unlocking with stored key;
2)It should check if composite key is still unlockable after unlocking database with standard unlock prompt;
3)It should ask for setting up Windows Hello again after changing the master key.

@Angelelz
Copy link
Owner

No. 1 should be a good addition.
No. 2 could be added but I don't think it's high priority.
No. 3 I have to check if there is any "ChangedMasterKey" event I can subscribe to, to be doable.

@Angelelz Angelelz added bug Something isn't working enhancement New feature or request labels Aug 19, 2019
@Angelelz Angelelz self-assigned this Aug 19, 2019
@Angelelz
Copy link
Owner

Ok, after tinkering a bit with the code:
No. 1 will be fixed but I will also add a warning after the deletion of WinHelloUnlock data. That way, when you unlock again (with standard prompt), the database will be treated like a new database and you will be asked to create WinHelloUnlock data.
No. 2 will not be added because the plugin would need to prompt the user for Windows Hello auth in order to check whether it can unlock the database.
No. 3 will not be added because there no event that notifies me whenever a database's master key has been changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant