Hardware keyboard & mice input #29
Conversation
include/ace/managers/mouse.h
Outdated
| * @param uwHiY Maximum cursor X position. | ||
| * @param uwHiY Maximum cursor Y position. | ||
| */ | ||
| void mouseSetBounds( |
There was a problem hiding this comment.
When we have support for "multiple" simultaneous mouse handling... We should be able to set bounds for specific mouse.
Think about possibility to make split screen games with 2 connected mouses.
include/ace/utils/custom.h
Outdated
| /** | ||
| * Bit value macro - useful for setting & testing bits. | ||
| */ | ||
| #define BV(x) (1 << (x)) |
There was a problem hiding this comment.
Should this be moved to more generic file?
src/ace/managers/mouse.c
Outdated
| // determine mouse movement direction which takes into account joyxdat | ||
| // underflows and overflows. | ||
|
|
||
| if(g_sMouseManager.ubPortFlags & MOUSE_PORT_1) { |
There was a problem hiding this comment.
This IFs should be totally a function with few variables. Only 4 hardcoded elements varies.
src/ace/managers/mouse.c
Outdated
| UWORD uwPotMask = 0; | ||
|
|
||
| // Enable RMB & MMB | ||
| if(ubPortFlags & MOUSE_PORT_1) { |
There was a problem hiding this comment.
This IFs should be totally a function with few variables. Only 1 hardcoded element varies.
There was a problem hiding this comment.
Not really, since there is no need for that. Also, mouseCreate() is short enough to have this stuff written as it is right now. No need for moving every repetitive code to separate fn.
tehKaiN
force-pushed
the
hardware-input
branch
from
483434c
to
b985981
Compare
This pull requests closes pull request #13 and does some work for #24 . Also, it brings as closer to abandoning intuition.