[WIP] Add basic writers for going from List<SubtitleItem> --> Stream #31
Conversation
|
I'm finished with writing the writers (hah) for now, so this should be good to merge. I may come back and add some of the other formats at some point if we decide we need them, but I don't really foresee that happening for anything except for maybe WebVTT. Something I noticed was that multiline SSA/ASS dialogue doesn't get split into multiple items in the SubtitleItem.Lines list, but there's a TODO on line 96 of SsaParser.cs to do this, which I figure I could pretty quickly do. Also, as I said, I'm planning on adding some sort of formatting/styling stripping, so I could do both of these at the same time if you want, either in a new PR, or this one, or individually. Up to you what you want to do, or if you want them or not. |
|
Good job with the writers! |
#25 mentioned you'd be open to a PR for adding writers, and since I'm writing some for our project anyways, I decided to submit it upstream for others to use.
Currently I've implemented the SSA writer with both sync and async methods. I moved the consts from
SsaParser.csinto a new util class (SsaFormatConstants.cs) so that I didn't have to have duplicates in the writer. I'm writing to a stream since our usecase requires that over a file (since it's serving over the network), but it shouldn't be to difficult to either create methods that do write to a file, or just have the user write the stream to the file themselves.I'm only familiar with (and our service only requires) SSA and SRT writers, so it's likely that's all I'll add support for.
I'll get the SRT writer finished up asap so this can actually be merged, but let me know if you have any concerns, or need me to change anything. If you're interested, I may also submit another PR with some more additions, like the option to strip out formatting codes from SSA (again, I'll be doing this anyways since we require it, might as well upstream it if you want it).