Update DG with Command History and Command Assistant #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yucheng11122017
approved these changes
Nov 8, 2021
docs/DeveloperGuide.md
Outdated
|
|
||
| The user keystroke will be read in `CommandBox#handleKeyStroke`. The user input will be evaluated by `SystemCommand#execute` to determine the appropriate help message to display. | ||
|
|
||
| Given below is an example usage scenario and how the Find mechanism behaves at each step. |
There was a problem hiding this comment.
Should be command assistant feature
docs/DeveloperGuide.md
Outdated
|
|
||
| The user keystroke will be read in `CommandBox#handleKeyStroke`, which will call the appropriate method in `CommandHistory` to retrieve the previous and next commands. The retrieved commands are passed into `CommandBox#commandTextField` to be displayed. | ||
|
|
||
| Given below is an example usage scenario and how the Find mechanism behaves at each step. |
There was a problem hiding this comment.
Should be command history feature
cookiedan42
approved these changes
Nov 8, 2021
docs/DeveloperGuide.md
Outdated
|
|
||
| Step 2. The user enters `find ` to search for a matching contact. | ||
|
|
||
| Step 3. `CommandBox#handleKeyStroke` reads `find ` keystroke and calls `SystemCommand#execute`. |
There was a problem hiding this comment.
is find a keystroke or a String?
Perhaps the space is a keystroke but it reads the String
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
=========================================
Coverage 70.75% 70.75%
Complexity 672 672
=========================================
Files 97 97
Lines 2086 2086
Branches 246 246
=========================================
Hits 1476 1476
Misses 519 519
Partials 91 91 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.