Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: try sort as ignore-case #8525

Merged
merged 3 commits into from
Mar 27, 2023
Merged

feat: try sort as ignore-case #8525

merged 3 commits into from
Mar 27, 2023

Conversation

bluelovers
Copy link
Contributor

#8368

current

  • A
  • B
  • a

expected

  • A
  • a
  • B

@AUTOMATIC1111
Copy link
Owner

Why are you using key in three cases but cmp in 4th?

@bluelovers
Copy link
Contributor Author

Why are you using key in three cases but cmp in 4th?

i use ChatGPT write it for me

@pangbo13
Copy link
Contributor

Looks like the cmp parameter was removed entirely in python3, https://docs.python.org/3.10/howto/sorting.html#the-old-way-using-the-cmp-parameter

@bluelovers
fix: remove cmp
fd672a7 
by ChatGPT
@AUTOMATIC1111
Copy link
Owner

the change in line 132 in modules/textual_inversion/textual_inversion.py is not needed

@AUTOMATIC1111 AUTOMATIC1111 merged commit c5e1efb into AUTOMATIC1111:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

@kbakdev kbakdev kbakdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bluelovers @AUTOMATIC1111 @pangbo13 @kbakdev