Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_clock.c location for stm32h723xg #15407

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

jasperjonker
Copy link
Contributor

@jasperjonker jasperjonker commented Apr 21, 2023

Summary of changes

I cannot build the code for a hello-world example for the NUCLEO_H723ZG. E.g. when I execute:

mbed-tools compile -c -t GCC_ARM -m NUCLEO_H723ZG

I get:

mbed-tools compile -c -t GCC_ARM -m NUCLEO_H723ZG
Configuring project and generating build system...
-- The C compiler identification is GNU 12.2.1
-- The CXX compiler identification is GNU 12.2.1
-- The ASM compiler identification is GNU
-- Found assembler: /opt/xpack-arm-none-eabi-gcc-12.2.1-1.2/bin/arm-none-eabi-gcc
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /opt/xpack-arm-none-eabi-gcc-12.2.1-1.2/bin/arm-none-eabi-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/xpack-arm-none-eabi-gcc-12.2.1-1.2/bin/arm-none-eabi-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Python3: /home/jasper/.pyenv/versions/mbed/bin/python3.11 (found version "3.11.3") found components: Interpreter 
-- Checking for Python package prettytable -- found
-- Checking for Python package future -- found
-- Checking for Python package jinja2 -- found
-- Checking for Python package intelhex -- found
-- Configuring done (1.3s)
CMake Error at CMakeLists.txt:16 (add_executable):
  Cannot find source file:

    /home/.../mbed-os/targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H723xG/TARGET_NUCLEO_H723ZG/system_clock.c

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc


-- Generating done (0.1s)
CMake Generate step failed.  Build files cannot be regenerated correctly.
ERROR: CMake invocation failed!

More information may be available by using the command line option '-v'.

With these changes I can confirm that I can build and flash it on the NUCLEO_H723ZG.

Impact of changes

Migration actions required

Documentation

I believe nothing


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Signed-off-by: Jasper Jonker <[email protected]>
@JohnK1987
Copy link

JohnK1987 commented Apr 21, 2023

Hello,

just for info when I made a custom target base on H725 I found few typos in the cmsis_nvic.h for the H723xg and I forgot on that. And I do not have this board so I can not test it. Maybe you can include it to your PR.

#if !defined(MBED_RAM1_START)
#define MBED_RAM_1START 0x24000000
#endif
#if !defined(MBED_RAM1_SIZE)
#define MBED1_RAM_SIZE 0x50000 // 320 KB
#endif

positions of 1 are probably wrong
BR, Jan

Signed-off-by: Jasper <[email protected]>
@jasperjonker
Copy link
Contributor Author

just for info when I made a custom target base on H725 I found few typos in the cmsis_nvic.h for the H723xg and I forgot on that. And I do not have this board so I can not test it. Maybe you can include it to your PR.

Thanks @JohnK1987 ! That made it compile. I will check next week if it works on a board

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2023

@ARMmbed/team-st-mcd Please review

@0xc0170 0xc0170 added needs: review release-type: patch Indentifies a PR as containing just a patch labels Apr 24, 2023
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, Thx

@jasperjonker
Copy link
Contributor Author

I tested it on a NUCLEO_H723ZG and it works. I updated the initial post. IMO ready to be reviewed/merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2023

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Apr 26, 2023
@mbed-ci
Copy link

mbed-ci commented Apr 26, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants