Load Sockethub dynamically, inform when unavailable #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the current hardcoded script tags in
app/index.html
as well as the initializer, in favor of a completely dynamic process of loading the libraries from a newsockethub
service.This is the first step toward making Sockethub configurable. But it also resolves the issue of only showing a blank screen when the libraries cannot be loaded and some other function fails subsequently.
With this changeset, failing to load the libs prevents the app from trying to load anything else and redirects to a special screen that informs the user about the situation. Later on, we can add a form field to make Sockethub configurable directly from that screen. But for now, it's already a big improvement in development, where it's very easy to forget running Sockethub before starting Hyperchannel.