Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Sockethub dynamically, inform when unavailable #284

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

raucao
Copy link
Member

@raucao raucao commented Feb 25, 2022

This removes the current hardcoded script tags in app/index.html as well as the initializer, in favor of a completely dynamic process of loading the libraries from a new sockethub service.

This is the first step toward making Sockethub configurable. But it also resolves the issue of only showing a blank screen when the libraries cannot be loaded and some other function fails subsequently.

With this changeset, failing to load the libs prevents the app from trying to load anything else and redirects to a special screen that informs the user about the situation. Later on, we can add a form field to make Sockethub configurable directly from that screen. But for now, it's already a big improvement in development, where it's very easy to forget running Sockethub before starting Hyperchannel.

Screenshot 2022-02-25 at 16-58-09 Hyperchannel

@raucao raucao merged commit 62b065b into master Mar 7, 2022
@raucao raucao deleted the feature/dynamic_sockethub_loading branch March 7, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant