Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incoming message corrections #261

Merged
merged 4 commits into from
Dec 28, 2021
Merged

Conversation

raucao
Copy link
Member

@raucao raucao commented Dec 24, 2021

Works in combination with sockethub/sockethub#649 (and will simply show additional messages when used with Sockethub versions that do not support it).

Adds the stanza ID as a new, separate property for message objects (needed for MAM), while the Sockethub change switches the ActivityStream object's "id" property to the XMPP <message> element's "id" attribute.

Left to do:

  • Only allow correcting the last message
  • Correction must come from the sender of the original message
  • Indicate in the UI that a message has been edited/replaced

refs #245

@raucao raucao marked this pull request as ready for review December 26, 2021 14:35
@raucao raucao requested a review from galfert December 26, 2021 14:35
Copy link
Contributor

@galfert galfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and confirmed it to be working 👍

@raucao raucao merged commit bde3513 into master Dec 28, 2021
@raucao raucao deleted the feature/xep-0308-message_correction branch December 28, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants