MISTAKE #1
Closed
MISTAKE #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu 20.04 ships Clang versions starting from 6.0. Additionally, the C++ libstd+ headers (libstdc++-9-dev) are now located in a different directory.
On Linux systems providing gettid() (Glibc 2.30+), the header is `unistd.h`, so the function must be tested also using such header. Upstream PR: rubinius/rubinius#3848. I've included it only from v4.7, because I can't produce a working Rubinius interpreter with the previous versions.
64kramsystem
added
bug
64kramsystem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set of patches that fix and update Rubiniuns interpreters, on modern systems. The contents are detailed in each commit.
Among the changes, the default Rubinius version has been bumped to v5.0, currently the latest.
Verified on an Ubuntu 20.04 system, with Rubinius versions 4.7 and 5.0.
It'd be best if this could be tested on other systems. Performance hint: compile with
JOBS=$(nproc) rvm instal rbx..., in order to use all the cores during the main compilation stage (where nproc is not present, just use the number of hardware threads).Closes rvm#5196.