Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files add #211

Merged
merged 3 commits into from
Oct 2, 2022
Merged

files add #211

merged 3 commits into from
Oct 2, 2022

Conversation

nitinp45
Copy link
Contributor

No description provided.

Copy link
Collaborator

@rishitsaiya rishitsaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nitinp45,

We have this version of HelloWorld in PHP already. So, if you can make this into some other logic like inserting a loop and printing multiple times or so would also do. Please change something at least as we already have similar code since past 2 years.

@rishitsaiya rishitsaiya added changes-required Changes are requested review-required Review is required labels Sep 30, 2022
Copy link
Contributor Author

@nitinp45 nitinp45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done

Copy link
Collaborator

@rishitsaiya rishitsaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! GTG!

@rishitsaiya rishitsaiya added hacktoberfest-accepted Hacktoberfest-2022 Accepted and removed changes-required Changes are requested review-required Review is required labels Oct 2, 2022
@rishitsaiya rishitsaiya merged commit ffee55d into 6-CSE:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest-2022 Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants