-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THREESCALE-1789: Add "Managed by operator" banner (UI) #3876
THREESCALE-1789: Add "Managed by operator" banner (UI) #3876
Conversation
It looks good like that, but I would rather follow Patternfly's design guidelines regarding inline alerts: https://www.patternfly.org/components/alert/design-guidelines#plain-inline-alerts: |
I made some changes. Now it looks like this: Now it uses a plan inline alert but there's no spacing between the title and the alert. I've been trying to fix it but I'm spending too much time and I think its better for somebody else with more experience to do it... @josemigallas |
@josemigallas I made some changes, I'd say it looks better now: |
Maybe make orange or something? Looks good. Just I'm not sure anybody would notice blue stuff :) Blue means all is fine. idk. Just saying. |
It would look like this: WDYT @josemigallas We can also have it as |
Better to me. But just an opinion, do as you want. |
With the description it now looks weird 😅. Maybe we don't use
On the other hand, I agree with this ☝🏻 |
After the last changes @josemigallas @akostadinov |
I think we could use the |
I added the EDIT: Still a codeclimate error but that one was there before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
a24b25b
to
b40c707
Compare
What this PR does / why we need it:
This replaces #3865. That got closed after merging #3857
The operator can manage porta resources through API. When a resource is managed by operator, we must inform the user about that.
#3857 implements the backend support (annotations). This PR implements the frontend, for now, just a banner in the relevant screens:
http://provider-admin.3scale.localhost:3000/buyers/accounts/4
http://provider-admin.3scale.localhost:3000/buyers/accounts/4/edit
http://provider-admin.3scale.localhost:3000/apiconfig/services/2
http://provider-admin.3scale.localhost:3000/apiconfig/services/2/edit
http://provider-admin.3scale.localhost:3000/p/admin/backend_apis/2
http://provider-admin.3scale.localhost:3000/p/admin/backend_apis/2/edit
Examples:
Which issue(s) this PR fixes
https://issues.redhat.com/browse/THREESCALE-1786
Verification steps
#show
or#edit
screens