-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix repeater for simple timestamps #568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munen
force-pushed
the
fix/repeaters-on-timestamps
branch
from
November 15, 2020 15:27
f204a41
to
5bb3ad2
Compare
munen
reviewed
Nov 15, 2020
I added support for deleting timestamps. |
Great job, again 👍 I'll add it to the changelog and will merge it in! |
munen
force-pushed
the
fix/repeaters-on-timestamps
branch
from
November 21, 2020 12:56
8de7c73
to
06b9065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeaters on simple timestamps are broken.
When the todo state changes, the last repeat property is created, a log entry is written and the planning item in the redux state is updated. The part in the title or description that represents the timestamp is not touched though, so while the item moves in the agenda, the change is not represented in text and is not persisted.
This fix connects the timestamps in title and description with their representation in planning items by keeping the id instead of generating a new one. It fixes the issue. I'm quite sure but not 100% certain that having planning items with the same id as parts of title or description won't cause problems. It makes sense, since the items with the same id represent the same thing. If it's preferred I could instead put a timestampId on the planning items and let them have their own unique id.