Docker Support #133
Merged
Docker Support #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document how to build your own image.
|
This looks great! Let's merge and see what happens(; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating a Docker image from the source code which has been requested in #132.
The Docker image makes it easier to run this service without the need to install the correct versions for
nodejs,yarn, etc.It also allows users to be able to run this service in a Kubernetes cluster or a Docker Swarm cluster.
This PR is still in progress while a pipeline has to be built around creating the Docker image and pushing it to some registry (e.g. Docker Hub).