-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logbook clocking #103
Logbook clocking #103
Conversation
Still need to add the ability to edit timestamps in logbook. Should probably also show the cumulative time, the way emacs proper does
Also prevent extra blank lines from being added when editing
Hi @jamesnvc This is great work! 🎊 I've had a first read through the code and it looks good so far(; I also quickly tested against a file of mine and apart from the missing calculated times, it worked fine. I think you're still going, so I'm not going to interfere with finishing the calculation of times. When you're done with the feature itself, it would be nice to have a unit test for the parser like these and an integration test like this one. If you didn't plan on doing them, I'd be happy to help out here. Please give me a ping when you're done on the feature and I'll go through the code one more time and test it against some more files. I'm stoked you're working on this and am very much looking forward to merging the PR and using the feature! Thank you very much 🙏 |
Thanks @munen! I've added some tests & they all seem to be passing now. Please let me know if there's anything else I should change/add. |
@jamesnvc This is exceptional work! I read through the code again and tested against huge real life Org files. Both your code as well as your tests are rock solid.
This PR is nothing but impeccable, there's nothing for this feature left to do(; I'll happily merge your changes in - meaning the feature will be available on organice.200ok.ch within a few minutes. Thank you for your amazing work - you'll make quite a few people very happy 🙏 🙇♂️ |
I updated the changelog and added attribution: 656cadd Thank you, again. This is a major step forward^^ |
Thank you for the kind words and for organice! Absolutely my pleasure :) |
Addresses #99 by adding a "Clock In/Out" action to header entries.