Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log renders above previously opened view component #864

Closed
tarnung opened this issue Jun 28, 2022 · 2 comments · Fixed by #869
Closed

Change log renders above previously opened view component #864

tarnung opened this issue Jun 28, 2022 · 2 comments · Fixed by #869
Assignees
Labels
bug Something isn't working

Comments

@tarnung
Copy link
Collaborator

tarnung commented Jun 28, 2022

Recently the changelog acts strangely for me.
I had cases where the changelog showed up double. The view started out scrolled somewhere into the middle of the changelog and as i scrolled down to the start of the history it repeated (again showing "general" and the whole change log beneath it).
Now i discovered an even stranger bug. I opened the change log from the settings menu and the change log again started scrolled down quite a bit. As i scrolled past the end i scrolled into the settings menu which was still there below the change log.

The bug is reproducible. It happens every time i open the changelog from the settings menu
I observed this on my android phone and in the desktop browser.

The starting scrolled down part is probably due to the browser keeping its scroll position since it does not load a new view but prepends the changelog to whatever view is shown already.

@tarnung tarnung added the bug Something isn't working label Jun 28, 2022
@munen
Copy link
Collaborator

munen commented Jun 30, 2022

Confirmed. That's a pretty ugly bug, too.

Additionally, the changelog shows up double for me from the "files" view, as well.

I propose fixing it by getting rid of the concept 'modal' for changelogs in the sense that it would be nice to have proper routes wherever we can.

@munen
Copy link
Collaborator

munen commented Jun 30, 2022

I have created a PR. Sample and Changelog now only work with their own routes /sample and /changelog. There's no weird 'modal logic' that puts stuff on top of stuff.

If you would like to review it, that would be nice. If you like it, please go ahead and merge it.

@munen munen self-assigned this Jun 30, 2022
@munen munen closed this as completed in #869 Jul 6, 2022
munen added a commit that referenced this issue Jul 7, 2022
     Reported in #864

     The regression was visible, for example, when going first to
     settings and then to the changelog. The changelog would then show
     in a 'scrolled down' position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants