Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color, NSLocalizedString #56

Closed
marinofaggiana opened this issue Nov 3, 2014 · 2 comments
Closed

Color, NSLocalizedString #56

marinofaggiana opened this issue Nov 3, 2014 · 2 comments
Labels
enhancement

Comments

@marinofaggiana
Copy link

Hello, I suggest to use a separate file for the location eg. CTAssetsPicketController.string and add a property for the colors used (fonts and buttons).

thanks for you work!
m.
@1and2papa
Copy link
Owner

Hi, I manage to keep this picker to conform UIAppearance. For most UI appearance, (e.g. fonts, buttons, text colors), it can be overridden by setting proper UIAppearance. If you find any views that does not work with that. Please let me know.

For the localised string, it should be okay. Will do so on next release.

@marinofaggiana
Copy link
Author

ok, thanks !

1and2papa added a commit that referenced this issue Nov 6, 2014
@1and2papa
#56 Move the localisable string to separated string table
1afc316
kentran added a commit to kentran/CTAssetsPickerController that referenced this issue Nov 10, 2014
@kentran
Merge branch 'master' of https://github.com/chiunam/CTAssetsPickerCon…
98e64ce 
…troller

# By Clement T
# Via Clement T
* 'master' of https://github.com/chiunam/CTAssetsPickerController:
  Update CocoaPods Spec
  Update README.md
  Update RELEASE-NOTES.md
  Resize screenshot
  Update Screenshot to iPhone 6
  1and2papa#56 Move the localisable string to separated string table
  1and2papa#57 Make the picker's toolbar to conform UIApperance so that it can be overridden
  Update CocoaPods Spec
  Update RELEASE-NOTES.md
  1and2papa#55 Fix: Pictures disappear until you do scrolling gesture when you take screenshot
  Rectify documentation

Conflicts:
	CTAssetsPickerDemo.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@1and2papa @marinofaggiana