Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checkpointing] ExitEvent storage and proof generation #838

Merged
merged 8 commits into from
Oct 31, 2022

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Oct 25, 2022

Description

Added functions to store and query exit events in state.go.
Added event root hash calculation which will be used as a parameter in block extra (one of the parameters for checkpoint), that gets signed by validators.
Added exit proof generation for users that want to exit.
Added relevant UTs for positive and negative cases.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal changed the title [Checkpointing] ExitEvent storage and proof generation [Checkpointing] ExitEvent storage and proof generation Oct 25, 2022
@goran-ethernal goran-ethernal force-pushed the EVM-84-Event-trie-storage-workflow branch from 30c4673 to 5804e63 Compare October 25, 2022 12:49
@goran-ethernal goran-ethernal self-assigned this Oct 25, 2022
@goran-ethernal goran-ethernal added the feature New update to Polygon Edge label Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature/v3-parity@c9b71a1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a6cbda3 differs from pull request most recent head 213aa83. Consider uploading reports for the commit 213aa83 to get more accurate results

@@                 Coverage Diff                  @@
##             feature/v3-parity     #838   +/-   ##
====================================================
  Coverage                     ?   53.33%           
====================================================
  Files                        ?      160           
  Lines                        ?    21306           
  Branches                     ?        0           
====================================================
  Hits                         ?    11364           
  Misses                       ?     9034           
  Partials                     ?      908           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

consensus/polybft/state.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but found some minor points to be addressed.

consensus/polybft/consensus_runtime.go Outdated Show resolved Hide resolved
consensus/polybft/state.go Outdated Show resolved Hide resolved
consensus/polybft/state.go Outdated Show resolved Hide resolved
consensus/polybft/state.go Outdated Show resolved Hide resolved
consensus/polybft/state_test.go Outdated Show resolved Hide resolved
consensus/polybft/state.go Show resolved Hide resolved
* JSON RPC point for generating exit proofs

* Comments fix
@Stefan-Ethernal Stefan-Ethernal merged commit ac2f523 into feature/v3-parity Oct 31, 2022
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-84-Event-trie-storage-workflow branch October 31, 2022 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants