Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting errors #675

Merged
merged 5 commits into from
Aug 9, 2022
Merged

Fix linting errors #675

merged 5 commits into from
Aug 9, 2022

Conversation

zivkovicmilos
Copy link
Contributor

Description

This PR resolves the linting errors outlined in the latest version of golangci-lint, as well as switches the import parser to goimports instead of gofmt

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@zivkovicmilos zivkovicmilos added the bug fix Functionality that fixes a bug label Aug 5, 2022
@zivkovicmilos zivkovicmilos self-assigned this Aug 5, 2022
@zivkovicmilos zivkovicmilos marked this pull request as draft August 5, 2022 10:38
@zivkovicmilos zivkovicmilos marked this pull request as ready for review August 5, 2022 10:46
Copy link
Contributor

@Kourin1996 Kourin1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blockchain/subscription.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #675 (1fa3f31) into develop (39a6abd) will increase coverage by 0.00%.
The diff coverage is 59.18%.

@@           Coverage Diff            @@
##           develop     #675   +/-   ##
========================================
  Coverage    48.65%   48.66%           
========================================
  Files          112      112           
  Lines        15364    15363    -1     
========================================
  Hits          7476     7476           
+ Misses        7254     7253    -1     
  Partials       634      634           
Impacted Files Coverage Δ
blockchain/subscription.go 72.00% <ø> (ø)
blockchain/testing.go 59.29% <ø> (ø)
consensus/ibft/consensus.go 0.00% <ø> (ø)
consensus/ibft/consensus_backend.go 0.00% <0.00%> (ø)
consensus/ibft/ibft.go 4.00% <0.00%> (ø)
consensus/ibft/pos.go 0.00% <ø> (ø)
consensus/ibft/sign.go 64.58% <ø> (ø)
consensus/ibft/verifier.go 0.00% <0.00%> (ø)
contracts/staking/query.go 71.42% <ø> (ø)
jsonrpc/errors.go 41.66% <ø> (ø)
... and 23 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zivkovicmilos zivkovicmilos merged commit d3d4f8a into develop Aug 9, 2022
@zivkovicmilos zivkovicmilos deleted the fix/linting-errors branch August 9, 2022 10:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants