-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linting errors #675
Merged
Merged
Fix linting errors #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkovicmilos
requested review from
lazartravica,
Kourin1996,
dbrajovic and
0xAleksaOpacic
as code owners
August 5, 2022 10:32
Kourin1996
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #675 +/- ##
========================================
Coverage 48.65% 48.66%
========================================
Files 112 112
Lines 15364 15363 -1
========================================
Hits 7476 7476
+ Misses 7254 7253 -1
Partials 634 634
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
dbrajovic
approved these changes
Aug 9, 2022
0xAleksaOpacic
approved these changes
Aug 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the linting errors outlined in the latest version of
golangci-lint
, as well as switches the import parser togoimports
instead ofgofmt
Changes include
Checklist
Testing