IBFT 2.0 #650
Merged
IBFT 2.0 #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement watchSync * Fix some linter errors and resolve conflicts * Rename newStatus channel * wait for a new status on end watch sync * Add guard to check ih bestPeer is not nil * Rename isValidator to match module encapsulation * Call watchSync on every newStatus * Close stream after featching blocks * Fix linter issues
* implement watchSync * Fix some linter errors and resolve conflicts * Fix current failed tests * Add mocks for sycer tests * Add syncer unit tests * Add PeerMap unit test * Add SyncPeerService unit test * Fix mockBlockchain in syncer * Add bufcon in vendor * Add client unittests in syncer * Rename newStatus channel * wait for a new status on end watch sync * Add guard to check ih bestPeer is not nil * Rename isValidator to match module encapsulation * Call watchSync on every newStatus * Add TestPeerConnectionUpdateEventCh * Add unit tests for GetBlocks of SyncPeerClient * Fix failed test * Fix lint error * Close stream after featching blocks * Fix linter issues * Fix failed tests Co-authored-by: AleksaOpacic <[email protected]>
zivkovicmilos
requested review from
zivkovicmilos,
lazartravica and
0xAleksaOpacic
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #650 +/- ##
===========================================
- Coverage 51.27% 48.65% -2.63%
===========================================
Files 109 112 +3
Lines 15825 15364 -461
===========================================
- Hits 8115 7476 -639
- Misses 7028 7254 +226
+ Partials 682 634 -48
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Kourin1996
suggested changes
Jul 28, 2022
Kourin1996
approved these changes
Jul 29, 2022
0xAleksaOpacic
approved these changes
Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides the integration logic with the go-ibft package, and introduces IBFT 2.0 into Polygon Edge.
Changes include
Breaking changes
The IBFT 2.0 upgrade introduces liveness fixes, which are by default breaking changes, as it alters the way messages are constructed.
This breaking change is breaking in a sense that an entire cluster running on pre IBFT 2.0 needs to be restarted to run on post IBFT 2.0 (all nodes in the cluster need to be running the latest version). The blockchain history remains intact.
This means that nodes running IBFT 2.0 version of Edge will not work with nodes not running IBFT 2.0 version of Edge (older versions) - all nodes in the cluster need to run IBFT 2.0 of Edge in order to work.
Checklist
Testing
Manual tests
Additional comments
Fixes EDGE-614