Skip to content

Commit

Permalink
rapidio: convert bus code to use bus_groups
Browse files Browse the repository at this point in the history
The bus_attrs field of struct bus_type is going away soon, dev_groups
should be used instead.  This converts the rapidio bus code to use the
correct field.

Cc: Matt Porter <[email protected]>
Cc: Alexandre Bounine <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
gregkh committed Sep 26, 2013
1 parent 3e358ac commit ed1d2da
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
2 changes: 1 addition & 1 deletion drivers/rapidio/rio-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ struct bus_type rio_bus_type = {
.name = "rapidio",
.match = rio_match_bus,
.dev_attrs = rio_dev_attrs,
.bus_attrs = rio_bus_attrs,
.bus_groups = rio_bus_groups,
.probe = rio_device_probe,
.remove = rio_device_remove,
.uevent = rio_uevent,
Expand Down
16 changes: 13 additions & 3 deletions drivers/rapidio/rio-sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,18 @@ static ssize_t bus_scan_store(struct bus_type *bus, const char *buf,

return rc;
}
static BUS_ATTR(scan, (S_IWUSR|S_IWGRP), NULL, bus_scan_store);

struct bus_attribute rio_bus_attrs[] = {
__ATTR(scan, (S_IWUSR|S_IWGRP), NULL, bus_scan_store),
__ATTR_NULL
static struct attribute *rio_bus_attrs[] = {
&bus_attr_scan.attr,
NULL,
};

static const struct attribute_group rio_bus_group = {
.attrs = rio_bus_attrs,
};

const struct attribute_group *rio_bus_groups[] = {
&rio_bus_group,
NULL,
};
2 changes: 1 addition & 1 deletion drivers/rapidio/rio.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ extern int rio_mport_scan(int mport_id);

/* Structures internal to the RIO core code */
extern struct device_attribute rio_dev_attrs[];
extern struct bus_attribute rio_bus_attrs[];
extern const struct attribute_group *rio_bus_groups[];

#define RIO_GET_DID(size, x) (size ? (x & 0xffff) : ((x & 0x00ff0000) >> 16))
#define RIO_SET_DID(size, x) (size ? (x & 0xffff) : ((x & 0x000000ff) << 16))

0 comments on commit ed1d2da

Please sign in to comment.