Skip to content

Commit

Permalink
leds:lp55xx: Correct Kconfig dependency for f/w user helper
Browse files Browse the repository at this point in the history
The commit [b678932: leds:lp55xx: fix firmware loading error]
tries to address the firmware file handling with user helper, but it
sets a wrong Kconfig CONFIG_FW_LOADER_USER_HELPER_FALLBACK.  Since the
wrong option was enabled, the system got a regression -- it suffers
from the unexpected long delays for non-present firmware files.

This patch corrects the Kconfig dependency to the right one,
CONFIG_FW_LOADER_USER_HELPER.  This doesn't change the fallback
behavior but only enables UMH when needed.

Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=944661
Fixes: b678932 ('leds:lp55xx: fix firmware loading error')
Cc: <[email protected]> # v4.2+
Signed-off-by: Takashi Iwai <[email protected]>
Signed-off-by: Jacek Anaszewski <[email protected]>
  • Loading branch information
tiwai authored and janaszewski committed Sep 17, 2015
1 parent 35bfe45 commit 2338f73
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/leds/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ config LEDS_LP55XX_COMMON
tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501"
depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || LEDS_LP8501
select FW_LOADER
select FW_LOADER_USER_HELPER_FALLBACK
select FW_LOADER_USER_HELPER
help
This option supports common operations for LP5521/5523/55231/5562/8501
devices.
Expand Down

0 comments on commit 2338f73

Please sign in to comment.