Skip to content

Commit

Permalink
debug: put user data dir in home dir, update versions of things (micr…
Browse files Browse the repository at this point in the history
  • Loading branch information
connor4312 authored Aug 7, 2023
1 parent 4083eee commit 6004a9f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.17
18.15
1 change: 1 addition & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@
"--disable-features=CalculateNativeWinOcclusion",
"--disable-extension=vscode.vscode-api-tests"
],
"userDataDir": "${userHome}/.vscode-oss-dev",
"webRoot": "${workspaceFolder}",
"cascadeTerminateToConfigurations": [
"Attach to Extension Host"
Expand Down
8 changes: 4 additions & 4 deletions build/npm/preinstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ const majorNodeVersion = parseInt(nodeVersion[1]);
const minorNodeVersion = parseInt(nodeVersion[2]);
const patchNodeVersion = parseInt(nodeVersion[3]);

if (majorNodeVersion < 16 || (majorNodeVersion === 16 && minorNodeVersion < 17)) {
console.error('\033[1;31m*** Please use node.js versions >=16.17.x and <17.\033[0;0m');
if (majorNodeVersion < 18 || (majorNodeVersion === 18 && minorNodeVersion < 15)) {
console.error('\033[1;31m*** Please use node.js versions >=18.15.x and <19.\033[0;0m');
err = true;
}
if (majorNodeVersion >= 17) {
console.warn('\033[1;31m*** Warning: Versions of node.js >= 17 have not been tested.\033[0;0m')
if (majorNodeVersion >= 19) {
console.warn('\033[1;31m*** Warning: Versions of node.js >= 19 have not been tested.\033[0;0m')
}

const path = require('path');
Expand Down

0 comments on commit 6004a9f

Please sign in to comment.