-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing documentation for 1.1 release (#457) #468
Conversation
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 29 29
Lines 272 272
Branches 26 26
=======================================
Hits 235 235
Misses 32 32
Partials 5 5
Continue to review full report at Codecov.
|
README.md
Outdated
./gradlew clean build | ||
./gradlew bootRun > /dev/null & | ||
./gradlew bootRun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will block terminal and next command won't be available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
README.md
Outdated
- Consistency with [Zalando RESTful API Guidelines](http://zalando.github.io/restful-api-guidelines/) | ||
- Referential integrity with [Zalando RESTful API Guidelines](http://zalando.github.io/restful-api-guidelines/) | ||
- New rules | ||
- Improve quick start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly does it mean? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> New quick start script and better integration testing approaches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 minor comments
cdbe154
to
3a497e3
Compare
@netme please have another look |
👍 |
1 similar comment
👍 |
Related to #457.