Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing documentation for 1.1 release (#457) #468

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

maxim-tschumak
Copy link
Contributor

Related to #457.

@codecov-io
Copy link

codecov-io commented Aug 8, 2017

Codecov Report

Merging #468 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files          29       29           
  Lines         272      272           
  Branches       26       26           
=======================================
  Hits          235      235           
  Misses         32       32           
  Partials        5        5
Flag Coverage Δ
#webui 86.39% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdae1b...3a497e3. Read the comment docs.

README.md Outdated
./gradlew clean build
./gradlew bootRun > /dev/null &
./gradlew bootRun
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will block terminal and next command won't be available

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated
- Consistency with [Zalando RESTful API Guidelines](http://zalando.github.io/restful-api-guidelines/)
- Referential integrity with [Zalando RESTful API Guidelines](http://zalando.github.io/restful-api-guidelines/)
- New rules
- Improve quick start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does it mean? :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> New quick start script and better integration testing approaches

Copy link
Contributor

@netme netme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 minor comments

@maxim-tschumak maxim-tschumak force-pushed the documentation-updates-for-1.1-release branch from cdbe154 to 3a497e3 Compare August 8, 2017 08:30
@maxim-tschumak
Copy link
Contributor Author

@netme please have another look
👍

@netme
Copy link
Contributor

netme commented Aug 8, 2017

👍

1 similar comment
@maxim-tschumak
Copy link
Contributor Author

👍

@maxim-tschumak maxim-tschumak merged commit 7892d69 into master Aug 8, 2017
@maxim-tschumak maxim-tschumak deleted the documentation-updates-for-1.1-release branch August 8, 2017 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants