Drop json_payload column.
#1282
Conversation
|
👍 |
| @@ -0,0 +1 @@ | |||
| ALTER TABLE api_review DROP COLUMN json_payload; | |||
There was a problem hiding this comment.
Before we drop this, we should consequently look into our database, whether api_definition is really filled as expected for the entire review history and merge the content if necessary.
There was a problem hiding this comment.
@vadeg I had a first look at the data. It looked actually, as if it is doing what it says and storing the request payload. For me this is a dumb idea ... however, we will have a gap of 146 rows, that have been called by url and will afterwards have no pointer to the API reviewed. I will approve as soon as the merge conflict is resolved.
vadeg
added
the
status: blocked
vadeg
force-pushed
the
gh-890-drop-json-payload-column
branch
from
f36c7d7
to
a1161e1
Compare
vadeg
removed
the
status: blocked
|
@tkrop the conflict has been resolved. |
|
👍 |
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
============================================
- Coverage 76.03% 76.02% -0.01%
Complexity 1017 1017
============================================
Files 187 187
Lines 2938 2937 -1
Branches 508 508
============================================
- Hits 2234 2233 -1
Misses 435 435
Partials 269 269
Continue to review full report at Codecov.
|
|
@tkrop I have resolved conflicts. Please review again. |
|
👍 |
Fixes #890