Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export docker images for client and server #761

Open
ghost opened this issue Jul 21, 2018 · 5 comments
Open

export docker images for client and server #761

ghost opened this issue Jul 21, 2018 · 5 comments

Comments

@ghost
Copy link

ghost commented Jul 21, 2018

to ease the use of Zally :-)
this could be done at the end of the CI pipe maybe

@roxspring
Copy link
Collaborator

Would be particularly awesome if, via #560, a custom jar of rules could be mounted into the server.

@vadeg
Copy link
Contributor

vadeg commented Aug 27, 2018

@maxim-tschumak do we have a docker hub account?

@maxim-tschumak
Copy link
Contributor

@vadeg no, but there is the Zalando open-source Docker registry :)

@roxspring
Copy link
Collaborator

Just had a play with GitHub Packages (as @zeitlinger mentioned in #964). Publishing is actually pretty straight forward and would just require a repo owner to enable actions and establish a secret GITHUB_USER and the following .github/workflows/docker-publish.yml

name: Docker Image CI
on: [push]
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v1
    - name: Publish Server Docker
      uses: elgohr/[email protected]
      with:
        name: zalando/zally/server
        workdir: ./server
        username: ${{ secrets.GITHUB_USER }}
        password: ${{ secrets.GITHUB_TOKEN }}
        registry: docker.pkg.github.com

... but the benefits are completely undermined by the Docker registry requiring credentials to docker pull the image. If we want people to just docker pull somehost/zalando/zally/server then Docker Hub or Zalando's own repository look to be preferrable.

@Jean-Mercier
Copy link

hello do we have a news about this issue ?

it's could be more easy to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants